Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix Benchmark Regressions in Polkadot Parachain Auction System #5139

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Fix Benchmark Regressions in Polkadot Parachain Auction System #5139

merged 5 commits into from
Mar 17, 2022

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Mar 16, 2022 •
edited
Loading

#5138

Most of these breaks were introduced with the Lease Period Offset, and just needed to adjust the block number that events happen on.

@shawntabrizi
Copy link
Member Author

/benchmark runtime polkadot runtime_common::auctions

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 16, 2022
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 16, 2022
@shawntabrizi shawntabrizi added this to In progress in Runtime via automation Mar 16, 2022
@ggwpez
Copy link
Member

ggwpez commented Mar 16, 2022 •
edited
Loading

These two still fail:

  • runtime_parachains::ump: UnknownMessageIndex
  • pallet_election_provider_multi_phase: SignedCannotPayDeposit

@shawntabrizi shawntabrizi changed the title Fix Benchmark Regressions in Polkadot Fix Benchmark Regressions in Polkadot Parachain Auction System Mar 16, 2022
@shawntabrizi
Copy link
Member Author

@ggwpez yeah, these are just the pallet I know about, so lets have this be one pr, and then look at the others in follow up

Runtime automation moved this from In progress to Needs Audit Mar 16, 2022
@ggwpez
Copy link
Member

ggwpez commented Mar 17, 2022

I think we should wait until paritytech/substrate#11057 is merged and then pull lastest Substrate/master in here.
Then the runtime_parachains::ump should be the only failing one.

@shawntabrizi
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f170bd6 into master Mar 17, 2022
@paritytech-processbot paritytech-processbot bot deleted the shawntabrizi-fix-benchmarks branch March 17, 2022 15:56
Runtime automation moved this from Needs Audit to Done Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderobe coderobe coderobe approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
Runtime
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawntabrizi @ggwpez @coderobe