Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bump transaction version (polkadot & kusama) #5690

Merged
merged 2 commits into from Jun 17, 2022
Merged

bump transaction version (polkadot & kusama) #5690

merged 2 commits into from Jun 17, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Jun 17, 2022 •
edited

we need a transaction_version bump on kusama and polkadot because we have index changes in the treasury pallet

[Treasury] idx: 18 (calls: 4 -> 5, storage: 4)
           [+] calls: spend
           [removeApproval] idx: 3 -> 4 (args: 1)
                            (Compact<u32>)

It looks like the ordering changed when spend was introduced with paritytech/substrate#11124

see also #5679 (comment)

@coderobe coderobe added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 17, 2022
@kianenigma
Copy link
Contributor

Sounds reasonable to me.

@coderobe coderobe merged commit 5e1ff57 into release-v0.9.25 Jun 17, 2022
@coderobe coderobe deleted the coderobe/bump_txver_25 branch June 17, 2022 13:05
coderobe added a commit that referenced this pull request Jun 17, 2022
@coderobe
bump transaction version (polkadot & kusama) (#5690)
cad509b 
* kusama: bump transaction_version to 12

* polkadot: bump transaction_version to 13
@gilescope
Copy link
Contributor

Looks like westend is generally kept in line with these two so you might want to bump that also. If it were me I'd bump rococo up too. Not really convinced rococo should be at 0 given that it's a public testnet.

@coderobe
Copy link
Contributor Author

They're not in sync & westend does not use the pallet, thus is unaffected

paritytech-processbot bot pushed a commit that referenced this pull request Jun 21, 2022
@coderobe
bump versions to 0.9.25 (#5684)
06f3bff 
* kusama: bump spec_version to 9250

* polkadot: bump spec_version to 9250

* rococo: bump spec_version to 9250

* westend: bump spec_version to 9250

* bump version to 0.9.25

* bump transaction version (polkadot & kusama) (#5690)

* kusama: bump transaction_version to 12

* polkadot: bump transaction_version to 13
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@coderobe
bump versions to 0.9.25 (#5684)
64df4d5 
* kusama: bump spec_version to 9250

* polkadot: bump spec_version to 9250

* rococo: bump spec_version to 9250

* westend: bump spec_version to 9250

* bump version to 0.9.25

* bump transaction version (polkadot & kusama) (#5690)

* kusama: bump transaction_version to 12

* polkadot: bump transaction_version to 13
@mnaamani mnaamani mentioned this pull request Mar 21, 2023
Merged
28 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coderobe @kianenigma @gilescope