Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights, attempt two (0.9.31) #6189

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Conversation

coderobe
Copy link
Contributor

#6173 regenerated with paritytech/substrate#12482 applied

@coderobe coderobe added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 26, 2022
@coderobe coderobe mentioned this pull request Oct 26, 2022
14 tasks
Weight::from_ref_time(5_652_326_000 as u64)
.saturating_add(T::DbWeight::get().reads(6 as u64))
.saturating_add(T::DbWeight::get().writes(6 as u64))
// Minimum execution time: 125_577 nanoseconds.
Weight::from_ref_time(128_422_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump down

Comment on lines -90 to +94
Weight::from_ref_time(78_376_000 as u64)
// Standard Error: 2_253_708
.saturating_add(Weight::from_ref_time(221_428_037 as u64).saturating_mul(r as u64))
.saturating_add(T::DbWeight::get().reads(4 as u64))
// Minimum execution time: 76_733 nanoseconds.
Weight::from_ref_time(707_216_284 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x10 jump up

Comment on lines -103 to +108
Weight::from_ref_time(55_946_000 as u64)
// Standard Error: 2_268_396
.saturating_add(Weight::from_ref_time(221_648_859 as u64).saturating_mul(r as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
// Minimum execution time: 52_748 nanoseconds.
Weight::from_ref_time(683_979_746 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x10 jump up

Comment on lines -142 to +148
fn submit_unsigned(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
Weight::from_ref_time(0 as u64)
// Standard Error: 7_000
.saturating_add(Weight::from_ref_time(874_000 as u64).saturating_mul(v as u64))
// Standard Error: 14_000
.saturating_add(Weight::from_ref_time(39_000 as u64).saturating_mul(t as u64))
// Standard Error: 23_000
.saturating_add(Weight::from_ref_time(10_873_000 as u64).saturating_mul(a as u64))
// Standard Error: 35_000
.saturating_add(Weight::from_ref_time(2_257_000 as u64).saturating_mul(d as u64))
fn submit_unsigned(_v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
// Minimum execution time: 6_771_975 nanoseconds.
Weight::from_ref_time(6_832_732_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up

Comment on lines -163 to +165
fn feasibility_check(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
Weight::from_ref_time(0 as u64)
// Standard Error: 12_000
.saturating_add(Weight::from_ref_time(895_000 as u64).saturating_mul(v as u64))
// Standard Error: 25_000
.saturating_add(Weight::from_ref_time(18_000 as u64).saturating_mul(t as u64))
// Standard Error: 42_000
.saturating_add(Weight::from_ref_time(8_673_000 as u64).saturating_mul(a as u64))
// Standard Error: 63_000
.saturating_add(Weight::from_ref_time(1_598_000 as u64).saturating_mul(d as u64))
fn feasibility_check(v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
// Minimum execution time: 5_640_118 nanoseconds.
Weight::from_ref_time(5_681_788_000 as u64)
// Standard Error: 18_489
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up

Comment on lines -153 to +164
Weight::from_ref_time(0 as u64)
// Standard Error: 88_000
.saturating_add(Weight::from_ref_time(60_894_000 as u64).saturating_mul(v as u64))
// Standard Error: 88_000
.saturating_add(Weight::from_ref_time(379_000 as u64).saturating_mul(d as u64))
/// The range of component `d` is `[0, 5000]`.
fn clean_defunct_voters(v: u32, _d: u32, ) -> Weight {
// Minimum execution time: 277_672_844 nanoseconds.
Weight::from_ref_time(278_514_899_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge jump up

Comment on lines -175 to +185
Weight::from_ref_time(0 as u64)
// Standard Error: 691_000
.saturating_add(Weight::from_ref_time(57_805_000 as u64).saturating_mul(v as u64))
// Standard Error: 46_000
.saturating_add(Weight::from_ref_time(3_139_000 as u64).saturating_mul(e as u64))
// Minimum execution time: 28_457_507 nanoseconds.
Weight::from_ref_time(28_618_929_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more huge jump up

Comment on lines -344 to +365
Weight::from_ref_time(0 as u64)
// Standard Error: 579_000
.saturating_add(Weight::from_ref_time(161_445_000 as u64).saturating_mul(v as u64))
// Standard Error: 55_000
.saturating_add(Weight::from_ref_time(22_905_000 as u64).saturating_mul(n as u64))
.saturating_add(T::DbWeight::get().reads(192 as u64))
// Minimum execution time: 441_741 nanoseconds.
Weight::from_ref_time(444_325_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up

Comment on lines -368 to +390
Weight::from_ref_time(0 as u64)
// Standard Error: 375_000
.saturating_add(Weight::from_ref_time(41_603_000 as u64).saturating_mul(v as u64))
// Standard Error: 375_000
.saturating_add(Weight::from_ref_time(38_528_000 as u64).saturating_mul(n as u64))
// Standard Error: 9_578_000
.saturating_add(Weight::from_ref_time(41_537_000 as u64).saturating_mul(s as u64))
// Minimum execution time: 25_700_092 nanoseconds.
Weight::from_ref_time(25_792_272_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump up

Comment on lines -385 to +407
Weight::from_ref_time(310_326_000 as u64)
// Standard Error: 56_000
.saturating_add(Weight::from_ref_time(6_164_000 as u64).saturating_mul(v as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
// Minimum execution time: 3_338_127 nanoseconds.
Weight::from_ref_time(3_386_919_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x10 jump up

Comment on lines -90 to +94
Weight::from_ref_time(0 as u64)
// Standard Error: 15_000
.saturating_add(Weight::from_ref_time(7_134_000 as u64).saturating_mul(i as u64))
// Standard Error: 15_000
.saturating_add(Weight::from_ref_time(7_238_000 as u64).saturating_mul(e as u64))
// Minimum execution time: 856_131 nanoseconds.
Weight::from_ref_time(862_826_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump up

Comment on lines -51 to +52
Weight::from_ref_time(0 as u64)
// Standard Error: 56_000
.saturating_add(Weight::from_ref_time(13_944_000 as u64).saturating_mul(v as u64))
// Standard Error: 4_876_000
.saturating_add(Weight::from_ref_time(2_223_649_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 5_442_855 nanoseconds.
Weight::from_ref_time(5_493_581_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -61 to +63
Weight::from_ref_time(0 as u64)
// Standard Error: 79_000
.saturating_add(Weight::from_ref_time(14_480_000 as u64).saturating_mul(v as u64))
// Standard Error: 6_844_000
.saturating_add(Weight::from_ref_time(2_525_332_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 4_312_432 nanoseconds.
Weight::from_ref_time(4_352_242_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

Comment on lines -51 to +52
Weight::from_ref_time(0 as u64)
// Standard Error: 56_000
.saturating_add(Weight::from_ref_time(13_900_000 as u64).saturating_mul(v as u64))
// Standard Error: 4_843_000
.saturating_add(Weight::from_ref_time(2_216_812_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 5_430_677 nanoseconds.
Weight::from_ref_time(5_464_877_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -61 to +63
Weight::from_ref_time(0 as u64)
// Standard Error: 84_000
.saturating_add(Weight::from_ref_time(14_955_000 as u64).saturating_mul(v as u64))
// Standard Error: 7_259_000
.saturating_add(Weight::from_ref_time(2_615_111_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 4_281_157 nanoseconds.
Weight::from_ref_time(4_309_020_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment on lines -140 to +150
fn submit_unsigned(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
Weight::from_ref_time(0 as u64)
// Standard Error: 3_000
.saturating_add(Weight::from_ref_time(765_000 as u64).saturating_mul(v as u64))
// Standard Error: 7_000
.saturating_add(Weight::from_ref_time(34_000 as u64).saturating_mul(t as u64))
// Standard Error: 12_000
.saturating_add(Weight::from_ref_time(7_231_000 as u64).saturating_mul(a as u64))
// Standard Error: 18_000
.saturating_add(Weight::from_ref_time(1_703_000 as u64).saturating_mul(d as u64))
fn submit_unsigned(v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
// Minimum execution time: 4_793_536 nanoseconds.
Weight::from_ref_time(4_829_131_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -161 to +168
fn feasibility_check(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
Weight::from_ref_time(0 as u64)
// Standard Error: 4_000
.saturating_add(Weight::from_ref_time(789_000 as u64).saturating_mul(v as u64))
// Standard Error: 8_000
.saturating_add(Weight::from_ref_time(41_000 as u64).saturating_mul(t as u64))
// Standard Error: 13_000
.saturating_add(Weight::from_ref_time(5_713_000 as u64).saturating_mul(a as u64))
// Standard Error: 20_000
.saturating_add(Weight::from_ref_time(1_311_000 as u64).saturating_mul(d as u64))
fn feasibility_check(v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
// Minimum execution time: 3_977_796 nanoseconds.
Weight::from_ref_time(3_993_895_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -175 to +185
Weight::from_ref_time(0 as u64)
// Standard Error: 674_000
.saturating_add(Weight::from_ref_time(52_473_000 as u64).saturating_mul(v as u64))
// Standard Error: 44_000
.saturating_add(Weight::from_ref_time(2_826_000 as u64).saturating_mul(e as u64))
// Minimum execution time: 27_528_355 nanoseconds.
Weight::from_ref_time(27_615_108_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -368 to +389
Weight::from_ref_time(0 as u64)
// Standard Error: 450_000
.saturating_add(Weight::from_ref_time(38_224_000 as u64).saturating_mul(v as u64))
// Standard Error: 450_000
.saturating_add(Weight::from_ref_time(38_981_000 as u64).saturating_mul(n as u64))
// Standard Error: 11_498_000
.saturating_add(Weight::from_ref_time(16_085_000 as u64).saturating_mul(s as u64))
// Minimum execution time: 25_507_250 nanoseconds.
Weight::from_ref_time(25_649_540_000 as u64)
// Standard Error: 501_634
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -153 to +164
Weight::from_ref_time(0 as u64)
// Standard Error: 85_000
.saturating_add(Weight::from_ref_time(61_507_000 as u64).saturating_mul(v as u64))
// Minimum execution time: 278_626_833 nanoseconds.
Weight::from_ref_time(279_736_954_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -173 to +185
Weight::from_ref_time(0 as u64)
// Standard Error: 1_864_000
.saturating_add(Weight::from_ref_time(167_385_000 as u64).saturating_mul(v as u64))
// Standard Error: 124_000
.saturating_add(Weight::from_ref_time(9_721_000 as u64).saturating_mul(e as u64))
// Minimum execution time: 28_441_420 nanoseconds.
Weight::from_ref_time(28_674_262_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -51 to +53
Weight::from_ref_time(0 as u64)
// Standard Error: 58_000
.saturating_add(Weight::from_ref_time(14_001_000 as u64).saturating_mul(v as u64))
// Standard Error: 5_013_000
.saturating_add(Weight::from_ref_time(2_245_454_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 5_449_895 nanoseconds.
Weight::from_ref_time(5_493_777_000 as u64)
// Standard Error: 137_519
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -61 to +63
Weight::from_ref_time(0 as u64)
// Standard Error: 84_000
.saturating_add(Weight::from_ref_time(15_041_000 as u64).saturating_mul(v as u64))
// Standard Error: 7_315_000
.saturating_add(Weight::from_ref_time(2_619_056_000 as u64).saturating_mul(d as u64))
// Minimum execution time: 4_267_232 nanoseconds.
Weight::from_ref_time(4_311_499_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

Comment on lines -368 to +390
Weight::from_ref_time(0 as u64)
// Standard Error: 378_000
.saturating_add(Weight::from_ref_time(36_021_000 as u64).saturating_mul(v as u64))
// Standard Error: 378_000
.saturating_add(Weight::from_ref_time(34_834_000 as u64).saturating_mul(n as u64))
// Standard Error: 9_659_000
.saturating_add(Weight::from_ref_time(52_904_000 as u64).saturating_mul(s as u64))
// Minimum execution time: 25_695_485 nanoseconds.
Weight::from_ref_time(25_860_451_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump up from 0

fix compilation

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@coderobe
Copy link
Contributor Author

next blocker for this to build is paritytech/substrate#12558

@ggwpez
Copy link
Member

ggwpez commented Oct 26, 2022

The only case where there are a large number of storage ops is here (which is on master for Kusama, so should be fine?):
image
cc @koute @shawntabrizi

coderobe and others added 2 commits October 27, 2022 18:29
* Typo

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add multisig weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update multisig weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* update lockfile for {"substrate"}

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
@ggwpez
Copy link
Member

ggwpez commented Oct 27, 2022

Okay I think the ~3600 READ/WRITE is fine in on_init and is already live for a long time on the other runtimes.
On rococo it now happened since #5617 did not update the weights for the auctions.

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like runtime/rococo/src/weights/runtime_parachains_paras_inherent.rs was not updated.
No idea why. Maybe missing from a script?
In fact it was never updated in the release process so far.

@ggwpez
Copy link
Member

ggwpez commented Oct 27, 2022

Ah the para-inherents for rococo does not work. I remember there being an issue. Should be fine 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants