Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

approval distribution: trigger assignment/votes resend based on approval checking lag #7038

Merged
merged 9 commits into from
Apr 13, 2023
Merged

approval distribution: trigger assignment/votes resend based on approval checking lag #7038

merged 9 commits into from
Apr 13, 2023

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Apr 10, 2023 •
edited
Loading

Fixes #6414

TODO:

  • fix tests
  • versi test

@sandreim
Send lag update message
3a23be1 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Process ApprovalCheckingLagUpdate
3341a35 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Comput min age based on lag
7ea7ce6 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 10, 2023
@sandreim
fix comment
e6bb4ac 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim requested a review from rphmeier April 10, 2023 13:22
@sandreim
Copy link
Contributor Author

sandreim commented Apr 10, 2023 •
edited
Loading

Seems like I broken something while fixing tests ...

@sandreim
Fix tests
533eaef 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim marked this pull request as ready for review April 11, 2023 13:20
@sandreim sandreim added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 11, 2023
ordian
ordian approved these changes Apr 11, 2023
View reviewed changes
node/service/src/relay_chain_selection.rs Outdated Show resolved Hide resolved
@sandreim sandreim mentioned this pull request Apr 11, 2023
Open
@sandreim
Copy link
Contributor Author

Confirmed on Versi that we do not trigger aggression for finality lag as high as 50 blocks. Approval checking lag looks good.

@sandreim
Fix test build
dd27514 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Make the spawnhandle optional
215bd46 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
remove unused
6ddf786 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
1c6c714 
…/smarter_approval_distribution_aggression
@sandreim
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit ae96e09 into master Apr 13, 2023
@paritytech-processbot paritytech-processbot bot deleted the sandreim/smarter_approval_distribution_aggression branch April 13, 2023 10:10
This was referenced Jun 2, 2023
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
No open projects
Road to 1k paravalidators and 200 parachains
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

approval-distribution aggression should only trigger based on approval checking lag
3 participants
@sandreim @ordian @rphmeier