Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change Fixed to WeightInfoBounds for Polkadot #7077

Merged
merged 67 commits into from
Jul 19, 2023
Merged

Change Fixed to WeightInfoBounds for Polkadot #7077

merged 67 commits into from
Jul 19, 2023

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Apr 13, 2023 •
edited
Loading

Addresses #6785

The Polkadot XCM Weigher was previously using a fixed weight for each XCM instruction.
This PR changes that to actual benchmarked weights.
We were using 1_000_000_000 of weight in ref_time and 0 in proof_size.

The new weights are all way less than that in ref_time which means developers right now might be overpaying and could pay way less for weight for their messages.

@franciscoaguirre
Copy link
Contributor Author

bot bench $ xcm polkadot pallet_xcm_benchmarks::fungible

@franciscoaguirre franciscoaguirre force-pushed the cisco-polkadot-xcm-weight-info-bound branch from 0193228 to e164da6 Compare April 13, 2023 19:41
@franciscoaguirre
Copy link
Contributor Author

bot bench $ xcm polkadot pallet_xcm_benchmarks::fungible

@franciscoaguirre
Copy link
Contributor Author

bot clean
bot bench $ xcm polkadot pallet_xcm_benchmarks::fungible

@franciscoaguirre franciscoaguirre added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B1-note_worthy Changes should be noted in the release notes labels Apr 13, 2023
@franciscoaguirre
Copy link
Contributor Author

bot bench $ xcm polkadot pallet_xcm_benchmarks::generic

@ggwpez
Make CI fail on old files
c82f5cc 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update template
71983ac 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Apr 14, 2023
Closed
@franciscoaguirre
Copy link
Contributor Author

bot bench $ xcm kusama pallet_xcm_benchmarks::generic
bot bench $ xcm kusama pallet_xcm_benchmarks::fungible
bot bench $ xcm westend pallet_xcm_benchmarks::generic
bot bench $ xcm westend pallet_xcm_benchmarks::fungible
bot bench $ xcm rococo pallet_xcm_benchmarks::generic
bot bench $ xcm rococo pallet_xcm_benchmarks::fungible

@ggwpez ggwpez added the T1-runtime This PR/Issue is related to the topic “runtime”. label Apr 14, 2023
command-bot and others added 2 commits April 14, 2023 14:27
".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchma…
c7e31e2 
…rks::generic
@ggwpez
Update weights
7f4243e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Apr 14, 2023 •
edited
Loading

Updated manually.

bot cancel
bot clean

@ggwpez ggwpez marked this pull request as ready for review April 14, 2023 15:55
@franciscoaguirre
Copy link
Contributor Author

bot merge

@franciscoaguirre
Copy link
Contributor Author

bot help

@franciscoaguirre
Copy link
Contributor Author

bot rebase

@franciscoaguirre
Copy link
Contributor Author

bot fmt

@franciscoaguirre
Copy link
Contributor Author

bot clean

@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jul 18, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jul 18, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jul 18, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jul 18, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jul 18, 2023
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@franciscoaguirre franciscoaguirre requested review from a team and chevdor as code owners July 18, 2023 19:03
@franciscoaguirre franciscoaguirre mentioned this pull request Jul 18, 2023
Merged
@franciscoaguirre
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit e628e48 into master Jul 19, 2023
45 checks passed
@paritytech-processbot paritytech-processbot bot deleted the cisco-polkadot-xcm-weight-info-bound branch July 19, 2023 14:18
@bkontur
Copy link
Contributor

bkontur commented Jul 21, 2023

hmm, I wonder, how could this pass without companion to cumulus? probably job does not check benchmarks,
I bump polkadot ref in Cumulus and see compilation erorrs for benchmarks,
so I am porting this changes as a part of paritytech/cumulus#2860

@bkontur bkontur mentioned this pull request Jul 25, 2023
Closed
2 tasks
@KiChjang KiChjang mentioned this pull request Aug 15, 2023
Closed
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@ordian ordian ordian approved these changes

@kianenigma kianenigma kianenigma approved these changes

@ggwpez ggwpez ggwpez approved these changes

@sergejparity sergejparity sergejparity approved these changes

@gavofyork gavofyork Awaiting requested review from gavofyork

@chevdor chevdor Awaiting requested review from chevdor

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@franciscoaguirre @ggwpez @xlc @bkontur @KiChjang @ordian @kianenigma @sergejparity