This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove legacy network code #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
the
A3-in_progress
rphmeier
force-pushed
the
rh-remove-legacy-network
branch
from
d6bde7f
to
9137d40
Compare
rphmeier
force-pushed
the
rh-remove-legacy-network
branch
from
9137d40
to
511dc40
Compare
rphmeier
force-pushed
the
rh-remove-legacy-network
branch
from
511dc40
to
457d406
Compare
|
Looks good as far as I can tell. tests need fixing. |
montekki
reviewed
Feb 28, 2020
rphmeier
added
A0-please_review
montekki
approved these changes
Mar 3, 2020
rphmeier
commented
Mar 5, 2020
2 tasks
General-Beck
pushed a commit
to General-Beck/polkadot
that referenced
this pull request
Mar 19, 2020
* expunge legacy code from polkadot-network * mostly rip out old legacy protocol from service * ensure validation work is spawned by incoming messages * decouple availabliity store from network logic; clean up data flow * av_store: test helpers and use futures-abort * update polkadot-validation to pass n_validators when submitting chunks * fallible erasure-chunk fetching * implement `ErasureNetworking` for new network prot * API for registering availability store in network * fully integrate new network service into service * fix validation tests * scaffolding for porting collator over to new network * track connected validators' peer IDs and distribute collators' collations * helper in network for fetching all checked statements * fix adder-collator * actually register notifications protocol * Update service/src/lib.rs * merge with master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy Polkadot-specific networking code, replacing it with the version introduced in #788 . This is the second-to-last step in removing
NetworkSpecializationfrom the codebase.The protocol handler was extended with certain additional capabilities to support collators.