Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Fix to show the parent display name first #768

Merged
merged 4 commits into from May 8, 2020
Merged

Fix to show the parent display name first #768

merged 4 commits into from May 8, 2020

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented May 7, 2020 •
edited

@Tbaut Tbaut requested a review from niklabh May 7, 2020 21:50
@Tbaut Tbaut requested a review from erler May 7, 2020 22:58
niklabh
niklabh approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@niklabh niklabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine

erler
erler approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@erler erler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. Thanks for the enlightening link also (weren't aware of the existence of sub-ids) :)

@Tbaut Tbaut merged commit 7724f6a into master May 8, 2020
@Tbaut Tbaut deleted the tbaut-fix-display-name branch May 8, 2020 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklabh niklabh niklabh approved these changes

@erler erler erler approved these changes

Assignees
No one assigned
Labels
x- changelog-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tbaut @niklabh @erler