removed user from login/signup response #785

niklabh · 2020-05-15T11:51:27Z

Closes: #762

Tbaut

Wow this is a huge one, thanks a lot for this refactoring. I've tested very thoroughly and it works perfectly! Just found a couple things that I think could be improved.

auth-server/test/resolvers/mutation/addressLinkConfirm.spec.ts

auth-server/test/resolvers/mutation/login.spec.ts

* removed stray notification * removed stray notification bis

Tbaut

working well thanks

niklabh added 3 commits May 15, 2020 17:14

removed user from login/signup response

869c96e

removed user from login/signup frontend

f246c09

removed user

0a38e33

niklabh requested review from Tbaut and erler May 15, 2020 11:51

niklabh added the PR-1-please review label May 15, 2020

removed unused import

43e4140

Tbaut reviewed May 15, 2020

View reviewed changes

auth-server/test/resolvers/mutation/addressLinkConfirm.spec.ts Show resolved Hide resolved

auth-server/test/resolvers/mutation/addressLinkConfirm.spec.ts Outdated Show resolved Hide resolved

auth-server/test/resolvers/mutation/login.spec.ts Outdated Show resolved Hide resolved

Tbaut added PR-6-got comments and removed PR-1-please review labels May 15, 2020

Tbaut and others added 4 commits May 15, 2020 20:11

Remove unused notification schema (#787)

ba2bdce

* removed stray notification * removed stray notification bis

Merged master

623e3f1

removed invalid test

60a5e21

using -1 instead of 0

6c7d590

niklabh requested a review from Tbaut May 22, 2020 04:40

niklabh added PR-1-please review and removed PR-6-got comments labels May 22, 2020

Merge branch 'master' into niklabh-remove-user-from-response

b815112

Tbaut approved these changes May 25, 2020

View reviewed changes

Tbaut added x- changelog-feature and removed PR-1-please review labels May 25, 2020

Merge branch 'master' into niklabh-remove-user-from-response

6eb1a73

Tbaut merged commit b74bd3a into master May 25, 2020

Tbaut deleted the niklabh-remove-user-from-response branch May 25, 2020 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removed user from login/signup response #785

removed user from login/signup response #785

niklabh commented May 15, 2020

Tbaut left a comment

Tbaut left a comment

removed user from login/signup response #785

removed user from login/signup response #785

Conversation

niklabh commented May 15, 2020

Tbaut left a comment

Choose a reason for hiding this comment

Tbaut left a comment

Choose a reason for hiding this comment