This repository has been archived by the owner on Sep 22, 2021. It is now read-only.
Refactor threshold calculation and publication of @polkadot/util v0.2 #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
npm test script should be modified for jest. I am getting error when running ● Test suite failed to run |
niklabh
reviewed
May 22, 2020
Co-authored-by: Nikhil Ranjan <niklabh811@gmail.com>
|
Not sure I understand what you mean, I couldn't reproduce. This PR doesn't touch anything in front-end. |
Ah yes its in utils. Test working fine |
niklabh
approved these changes
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On step toward #783
getFailingThreshold(this is basically the inverse of getPassingThreshold)edit: for tests I double checked my findings with this tool