Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Markdown target _blank for opening link in new tab #844

Merged
merged 2 commits into from Jun 6, 2020
Merged

Markdown target _blank for opening link in new tab #844

merged 2 commits into from Jun 6, 2020

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Jun 5, 2020 •
edited

Closes: #826

@niklabh niklabh requested review from erler and Tbaut June 5, 2020 17:42
Tbaut
Tbaut approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, haven't tested but that's what the doc says.

@niklabh niklabh merged commit a44bd09 into master Jun 6, 2020
@niklabh niklabh deleted the niklabh-markdown-target-blank branch June 6, 2020 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@erler erler Awaiting requested review from erler

Assignees
No one assigned
Labels
x- changelog-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make external domain links open in new tab by default
2 participants
@niklabh @Tbaut