Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Use account component in preimage arguments #858

Merged
merged 7 commits into from Jun 8, 2020
Merged

Conversation

erler
Copy link
Collaborator

@erler erler commented Jun 8, 2020

Closes #851

Screenshot 2020-06-08 at 15 25 35

Applying methodArguments class conditionally is not very nice, but otherwise overflow would clip the left edge of the address identicon.

Tbaut and others added 5 commits June 8, 2020 16:52
…o.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…nfo.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…mInfo.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@erler
Copy link
Collaborator Author

erler commented Jun 8, 2020

Committed suggestions :)

@erler erler requested a review from Tbaut June 8, 2020 15:40
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 8, 2020

Did you test it? I didn't :) Happy to merge if you tell me it works.

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if it works.

@erler
Copy link
Collaborator Author

erler commented Jun 8, 2020

Works with account argument as in referendum 58

Displaying addresses in a batch of calls is kind of another thing afaic, so merging :)

@erler erler merged commit c4ec7e8 into master Jun 8, 2020
@erler erler deleted the erler-account-in-preimage branch June 8, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use account component for on chain accounts argument
2 participants