Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Fix ended countdown #986

Merged
merged 3 commits into from Aug 4, 2020
Merged

Fix ended countdown #986

merged 3 commits into from Aug 4, 2020

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Aug 4, 2020

No description provided.

@niklabh niklabh requested a review from Tbaut August 4, 2020 08:27
Tbaut
Tbaut suggested changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's valuable to have the block where it ended, it should just not be displayed when it's 0.

@niklabh niklabh requested a review from Tbaut August 4, 2020 08:33
@niklabh
Copy link
Contributor Author

niklabh commented Aug 4, 2020

I think it's valuable to have the block where it ended, it should just not be displayed when it's 0.

done

Tbaut
Tbaut approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well

@niklabh niklabh merged commit b121676 into master Aug 4, 2020
@niklabh niklabh deleted the niklabh-fix-blockcountdown branch August 4, 2020 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
x- changelog-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niklabh @Tbaut