Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Highlighting own post/proposals with pink border #994

Merged
merged 4 commits into from Aug 10, 2020

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Aug 8, 2020

#370

Added pink border around own post/proposals.

Screenshot from 2020-08-08 18-13-16

@niklabh niklabh changed the title Highlighting own proposals with pink border Highlighting own post/proposals with pink border Aug 8, 2020
@erler
Copy link
Collaborator

erler commented Aug 8, 2020

Just a styling suggestion: adding a pink border of 4px only on the left.
Screenshot 2020-08-08 at 11 29 10

This pushes the text obvs 4px to the right, so would need to override the left padding for this one or do some wrapper tricks, so that the text aligns with the ones on other cards.

@niklabh
Copy link
Contributor Author

niklabh commented Aug 8, 2020

Just a styling suggestion: adding a pink border of 4px only on the left.
Screenshot 2020-08-08 at 11 29 10

This pushes the text obvs 4px to the right, so would need to override the left padding for this one or do some wrapper tricks, so that the text aligns with the ones on other cards.

Done. Thankyou very much for the design

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Tbaut Tbaut merged commit 13003a8 into master Aug 10, 2020
@Tbaut Tbaut deleted the niklabh-pink-border-own-proposals branch August 10, 2020 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants