Added validation to not have duplicated rule names

This closes #32
paritytech · Aug 8, 2023 · dd909ab · dd909ab
1 parent b1c2c41
commit dd909ab
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/file/validator.ts b/src/file/validator.ts
@@ -30,7 +30,7 @@ const ruleSchema = Joi.object<Rule & { type: string }>().keys({
  * Remember to evaluate the rules with their custom rules
  */
 export const generalSchema = Joi.object<ConfigurationFile>().keys({
-  rules: Joi.array<ConfigurationFile["rules"]>().items(ruleSchema).required(),
+  rules: Joi.array<ConfigurationFile["rules"]>().items(ruleSchema).unique("name").required(),
   preventReviewRequests: Joi.object().keys(reviewersObj).optional().xor("users", "teams"),
 });
 

diff --git a/src/test/runner/config.test.ts b/src/test/runner/config.test.ts
@@ -75,6 +75,27 @@ describe("Config Parsing", () => {
         'Configuration file is invalid: "rules[0].type" must be one of [basic, debug]',
       );
     });
+
+    test("should fail with duplicated rule name", async () => {
+      api.getConfigFile.mockResolvedValue(`
+          rules:
+            - name: Default review
+              condition:
+                include: 
+                  - '.*'
+              type: basic
+              teams:
+                - team-example
+            - name: Default review
+              condition:
+                include: 
+                  - 'src'
+              type: basic
+              teams:
+                - team-2
+          `);
+      await expect(runner.getConfigFile("")).rejects.toThrowError("contains a duplicate value");
+    });
   });
 
   describe("regular expressions validator", () => {