Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to greenlight rule if author belongs to list #66

Closed
Bullrich opened this issue Aug 30, 2023 · 0 comments · Fixed by #69
Closed

Ability to greenlight rule if author belongs to list #66

Bullrich opened this issue Aug 30, 2023 · 0 comments · Fixed by #69
Assignees
@Bullrich
Milestone
Project launch

Comments

@Bullrich
Copy link
Collaborator

As requested by @the-right-joyce, let's add the ability that a rule can be ignored if the author belongs to a particular list (of teams).

Example proposal:

  - name: Opstooling
    condition:
      include:
        - '.*'
    type: basic
    ignoreFrom:
      - core-devs
    teams:
      - srlabs
@Bullrich Bullrich self-assigned this Aug 30, 2023
@Bullrich Bullrich linked a pull request Sep 5, 2023 that will close this issue
Added excludeAuthors feature #69
Merged
@Bullrich Bullrich mentioned this issue Sep 5, 2023
Merged
@Bullrich Bullrich added this to the Project launch milestone Sep 5, 2023
Bullrich added a commit that referenced this issue Sep 5, 2023
@Bullrich
Added excludeAuthors feature (#69)
f9bc9c8 
This adds the feature to exclude rules from being executed when the
author belongs to a particular team or list.
This resolves #66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Added excludeAuthors feature paritytech/review-bot
1 participant
@Bullrich