Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CI-Test into three separate jobs #7

Closed
Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #8
Closed

Split CI-Test into three separate jobs #7

Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #8
Assignees
@mutantcornholio @Bullrich
Milestone
Project launch

Comments

@Bullrich
Copy link
Collaborator

Bullrich commented Jul 6, 2023 

          Would you consider making these separate jobs? This way tests, linting and building would run in parallel and, most importantly, they will show a bigger picture.

Consider three scenarios:

  • Tests failed, codestyle and build status unknown
  • Tests, codestyle, build — all three jobs have failed status
  • Tests are red, build and codestyle are green

Two latter cases allow you to draw some conclusions about what's wrong even without reading the output. But they would be hidden behind tests failure in a sequential run.

Originally posted by @mutantcornholio in #2 (comment)
@Bullrich Bullrich mentioned this issue Jul 6, 2023
Merged
@Bullrich Bullrich added this to the Project launch milestone Jul 6, 2023
Bullrich added a commit that referenced this issue Jul 6, 2023
@Bullrich
Split CT into three steps (#8)
33bf2e7 
Spliced the continuous testing step into three separated steps.

Added the yarn install as a needed step that downloads the dependencies
(just to stop it from spamming three yarn installs at the same time).

Closes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mutantcornholio mutantcornholio

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Split CT into three steps paritytech/review-bot
2 participants
@mutantcornholio @Bullrich