Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework failed message to include ranks #80

Closed
Bullrich opened this issue Sep 13, 2023 · 0 comments · Fixed by #82
Closed

Rework failed message to include ranks #80

Bullrich opened this issue Sep 13, 2023 · 0 comments · Fixed by #82
Assignees
@Bullrich

Comments

@Bullrich
Copy link
Collaborator

Because of #61, the required reviewers, when belonging to a rank, are not listed.

We need to rework the message to show that.
@Bullrich Bullrich self-assigned this Sep 13, 2023
@Bullrich Bullrich changed the title Rework failed message Rework failed message to include ranks Sep 13, 2023
This was referenced Sep 15, 2023
Closed
Merged
Bullrich added a commit that referenced this issue Sep 16, 2023
@Bullrich
Added better rank report and testing (#82)
088b8b9 
Enhanced the check report, adding the information of the missing rank.
This resolves #80

Added tests that evaluate the ranking system, and how it applies the
rules. This resolves #81

For the `or` rule, we request the lowest required rank, and for the
`and` rule we request the highest rank.

In the case of `and-distinct` we request the highest rank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added better rank report and testing paritytech/review-bot
1 participant
@Bullrich