Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub shape migration #25

Closed
wants to merge 5 commits into from
Closed

Sub shape migration #25

wants to merge 5 commits into from

Conversation

Bullrich
Copy link
Collaborator

Installed subShape and migrated the code to use the library.

This resolves #24

Todo:

  • Make the subShape generated type ConfigFile match the interface ConfigurationFile.
  • Implement an XOR logic in the reviewers object
  • Implement a literal type for the type field in the rule.

@Bullrich Bullrich self-assigned this Jul 20, 2023
This was referenced Jul 21, 2023
Open
Merged
@Bullrich
Copy link
Collaborator Author

Won't do. Will use JOI instead

@Bullrich Bullrich closed this Aug 14, 2023
@Bullrich Bullrich deleted the subShape-migration branch August 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrysolovay harrysolovay Awaiting requested review from harrysolovay

Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate validations to SupShape
1 participant
@Bullrich