Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

[Cargo.toml] update rand to 0.7 (breaking change) #18

Merged
merged 3 commits into from Oct 16, 2019
Merged

Conversation

niklasad1
Copy link
Member

@parity-cla-bot
Copy link

It looks like @niklasad1 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@dvdplm
Copy link

dvdplm commented Sep 5, 2019

@niklasad1 @ordian is this a good time to update our fork with the upstream changes?

@ordian
Copy link
Member

ordian commented Sep 5, 2019

@dvdplm our fork has diverged a bit rust-bitcoin/rust-secp256k1@master...paritytech:master, so it could be quite involved, but we need to do this for sure.

@dvdplm
Copy link

dvdplm commented Sep 5, 2019

so it could be quite involved, but we need to do this for sure.

Has a stab at this. It's a bit fiddly but not too bad tbh. I'll hold off until @grbIzl is done with his work on ethkey.

@niklasad1
Copy link
Member Author

@dvdplm @ordian can we merge this?

@dvdplm
Copy link

dvdplm commented Oct 7, 2019

@niklasad1 there was some talk over on the dalek lib to skip 0.7 altogether (apparently a very minor change not worthy of a semver-minor bump). I honestly don't know why not upgrade (or conversely what the reasons are to upgrade).

Can you explain why we want to upgrade? Maybe you did already but I have goldfish memory... ;)

@dvdplm
Copy link

dvdplm commented Oct 7, 2019

Can you explain why we want to upgrade? Maybe you did already but I have goldfish memory... ;)

Nvm, ignore me. We've already made the decision to go with 0.7 when we merged the PR in parity-common.

@niklasad1
Copy link
Member Author

Yes, after openethereum/parity-ethereum#11139 lands it could make sense to merge this and use rand 0.7. However, I'm not sure if use this crate somewhere else than in parity-ethereum.

@dvdplm
Copy link

dvdplm commented Oct 8, 2019

I'm not sure if use this crate somewhere else than in parity-ethereum.

rust-libp2p uses upstream (https://github.com/rust-bitcoin/rust-secp256k1/) and substrate uses https://github.com/sorpaas/libsecp256k1-rs so I think parity-ethereum is the only one.

@dvdplm
Copy link

dvdplm commented Oct 8, 2019

Looks like CI needs a kick in the butt here. :/

@niklasad1
Copy link
Member Author

I changed the trait bounds in the tests after you approved it, ok to merge?

@ordian ordian merged commit 246aefe into master Oct 16, 2019
@ordian ordian deleted the na-bump-rand branch October 16, 2019 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants