Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-std compatibility #26

Merged
merged 30 commits into from
Jul 11, 2023
Merged

Add no-std compatibility #26

merged 30 commits into from
Jul 11, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jun 26, 2023

Add no-std feature gate:

  • no_std is activated in case of deactivated std feature
  • removes thiserror because it's not no-std compatible
  • removes full feature from codec import (deprecated)

CI changes:

  • Adds a Check no_std build
  • Adds extra crate testing/no_std to ensure scale-encode-derive is no_std by CI

closes #25

@haerdib haerdib requested a review from a team as a code owner June 26, 2023 06:35
@jsdw
Copy link
Collaborator

jsdw commented Jun 26, 2023

I'm out for a few days so apologies if I'm a bit slow to look at this; I'll try to find time soon though!

@haerdib
Copy link
Contributor Author

haerdib commented Jun 26, 2023

There's no hurry from my side, so take your time 👍

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; it's been a busy last couple of weeks!

This looks amazing; great job!

Copy link
Contributor

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsdw jsdw merged commit c616353 into paritytech:main Jul 11, 2023
8 checks passed
@jsdw jsdw mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no_std support
5 participants