Replace Range variant with built-in composite definitions #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes more sense to me, range is like any other composite type which contains inner types, the logic associated to its usage doesn't need to be in the primitive of scale-info but instead just a description similar to other composite types. |
dvdplm
approved these changes
Aug 31, 2021
| @@ -271,9 +269,6 @@ pub enum TypeDef<T: Form = MetaForm> { | |||
| /// A type representing a sequence of bits. | |||
| #[codec(index = 7)] | |||
| BitSequence(TypeDefBitSequence<T>), | |||
| /// A Range type. | |||
| #[codec(index = 8)] | |||
| Range(TypeDefRange<T>), | |||
There was a problem hiding this comment.
Do you think we should make TypeDef be #[non_exhaustive]?
There was a problem hiding this comment.
I'm not sure because all TypeDef variants need to be handled usually, a wildcard might not make sense.
|
My vote needs to be for “much worse”, but since scale-info is not mapping to constructs, seems “sensible”, aka like Option would need to do more magic to detect. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now describes precisely the encoding of the two range types introduces in paritytech/parity-scale-codec#269.
The extra variant added in #124 would mean that if additional
Rangetypes were added it would have to be a breaking change.Also
Rangetype definitions are not general SCALE concepts, they are just another "built-in" type that we can add to the prelude - e.g.Option,Resultetc.Required for #129 to prevent possible future breaking changes.
/cc @jacogr