Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Metadata supertrait #15

Merged
merged 2 commits into from Jun 17, 2020
Merged

Remove Metadata supertrait #15

merged 2 commits into from Jun 17, 2020

Conversation

ascjones
Copy link
Member

Since multiple traits for id and def were removed, the Metadata supertrait has become redundant. The default impl has been replaced by a free function.

@ascjones ascjones requested a review from Robbepop June 17, 2020 06:51
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 9d8d1d9 into master Jun 17, 2020
@ascjones ascjones deleted the aj-remove-metadata-trait branch June 17, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants