Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore leading :: for crate access #152

Merged
merged 11 commits into from Apr 13, 2022
Merged

Restore leading :: for crate access #152

merged 11 commits into from Apr 13, 2022

Conversation

ascjones
Copy link
Member

@ascjones ascjones commented Apr 13, 2022 •
edited

Fix for #151.

Restores the :: prefix for accessing ::scale_info or its alias. Without this it will fail when using no_implicit_prelude

@ascjones ascjones marked this pull request as ready for review April 13, 2022 10:21
@ascjones ascjones requested review from jsdw and cmichi April 13, 2022 10:32
@ascjones ascjones mentioned this pull request Apr 13, 2022
Closed
jsdw
jsdw approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascjones ascjones merged commit 7140f90 into master Apr 13, 2022
@ascjones ascjones deleted the aj/fix-crate-access branch April 13, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascjones @cmichi @jsdw