Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Rc TypeInfo ✨ #185

Merged
merged 1 commit into from Jun 21, 2023
Merged

Conversation

EvolveArt
Copy link
Contributor

I have a merkle tree implementation that uses Rc and I want to store that within my substrate runtime but it's not possible so let make it happen!

@EvolveArt
Copy link
Contributor Author

hey @niklasad1 want me to bump the version before merging ?

@EvolveArt
Copy link
Contributor Author

EvolveArt commented Jun 17, 2023

Clippy seems to be complaining for no reasons too

EDIT: Why is cargo.lock ignored ?

@jsdw
Copy link
Contributor

jsdw commented Jun 17, 2023

Cargo lock is meaningless in library crates (upstream dependencies will ignore it and generate their own cargo locks instead etc)

The clippy errors are possibly just new errors that appeared since rust was updated. The cleanest approach would be another PR that runs a clippy --fix etc to sort these out :)

@EvolveArt
Copy link
Contributor Author

Sounds good thanks for the quick answer @jsdw !

@jsdw
Copy link
Contributor

jsdw commented Jun 17, 2023

Oh and no need for any version bumps; that'll be taken care of when we do a release :)

@EvolveArt
Copy link
Contributor Author

Oh and no need for any version bumps; that'll be taken care of when we do a release :)

Thanks I do have something weird happening in my project tho :
When using my fork as a dependency it breaks all the other scale-info types implementations :(

You can checkout this PR to see

@jsdw
Copy link
Contributor

jsdw commented Jun 17, 2023

Oh and no need for any version bumps; that'll be taken care of when we do a release :)

Thanks I do have something weird happening in my project tho : When using my fork as a dependency it breaks all the other scale-info types implementations :(

You can checkout this PR to see

I haven't checked, but I'm guessing it's because there are now multiple versions of scale-info in your cargo tree; use the cargo.toml patch stuff if you aren't already to ensure all scale-infos use your fork :)

@EvolveArt
Copy link
Contributor Author

Great! Could we merge this ? @jsdw or anything blocking let me know

@jsdw
Copy link
Contributor

jsdw commented Jun 21, 2023

The clippy errors are possibly just new errors that appeared since rust was updated. The cleanest approach would be another PR that runs a clippy --fix etc to sort these out :)

This still needs fixing; I'll open a new PR to address those and then when this branch is updated and passing we can merge it!

@jsdw
Copy link
Contributor

jsdw commented Jun 21, 2023

Edit: nevermind; re-ran the job and it passed!

@jsdw jsdw merged commit 18d3191 into paritytech:master Jun 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants