Use PortableRegistry for encoding and serializing #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
force-pushed
the
aj-encode-readonly
branch
from
d0d6326
to
15acba8
Compare
# Conflicts: # src/registry.rs
ascjones
changed the title
dvdplm
reviewed
Jan 5, 2021
| @@ -296,6 +297,7 @@ fn test_recursive_type_with_box() { | |||
| ] | |||
| }); | |||
|
|
|||
| let registry: PortableRegistry = registry.into(); | |||
There was a problem hiding this comment.
I guess you could do serde_json::to_value::<PortableRegistry>(registry.into()) but that's not better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes custom encoding/serialization from the
Registryand instead uses thePortableRegistrywhich already provides aFrom<Registry>impl.