New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Value type, with serde and scale impls #1
Conversation
src/lib.rs
Outdated
assert_eq!(result, 4); | ||
} | ||
// Copyright 2019-2022 Parity Technologies (UK) Ltd. | ||
// This file is part of subxt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// This file is part of subxt. | |
// This file is part of scale-value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh good spot; need to go around and change these copyright headers now :)
…alizing/deserializing more flexible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(though at the time of writing, going from a static type to a scale value hasn't been implemented yet)(edit: I did add this).The main use case for this crate offhand will be allowing subxt to work with dynamic values more, and be able to provide back a representation for scale encoded bytes that a static type may not exist for.