-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developed action #1
Conversation
has full functionality and fetches the issues of a given repository
@@ -0,0 +1 @@ | |||
* @paritytech/opstooling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unknown owner on line 1: make sure the team @paritytech/opstooling exists, is publicly visible, and has write access to the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is failing because it was set in the other organization. Should work once merged in ours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess the opstooling should have admin access in this repo and it should be ok
.github/workflows/publish.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy and paste from https://github.com/paritytech/github-issue-sync/blob/master/.github/workflows/publish.yml
few questions:
|
No, we need one step per repo (so it can be fine tuned per repo). In the example I added at the bottom of the readme, it handles 3 repos in the same action. What this your action?
The reason for the PAT is for individual use. We can use pthe github app to generate the access token just like we do it in github-issue-sync
I wanted to create that step in a separate commit. It also brings the question, does team refer to members of the organization?
Both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but certainly needs pagination for issues query, hope we can add it right after we merge this initial
uses: slackapi/slack-github-action@v1.23.0 | ||
with: | ||
channel-id: 'CHANNEL_ID,ANOTHER_CHANNEL_ID' | ||
slack-message: "Stale issues this week: \n$LOCAL_ISSUES \n$ABC_ISSUES \n$XYZ_ISSUES" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we make an example with all our repos in https://github.com/paritytech/opstooling/tree/master/.github/workflows ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as soon as I have a Matrix bot I'll have it running!
I can make one with no Matrix bot but that will still work in the intended way.
|
||
Stale issues this week: | ||
### Repo example/local has 1 stale issues | ||
- [Stop AI from controlling the world](https://github.com/example/local/issues/15) - Stale for 25 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
} | ||
|
||
export const fetchIssues = async (octokit: InstanceType<typeof GitHub>, daysStale: number, repo: Repo): Promise<IssueData[]> => { | ||
const issues = await octokit.rest.issues.listForRepo({ ...repo, per_page: 100, state: "open" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to add pagination
as at least this one https://github.com/paritytech/ink has > 100
may be as separate ticket would also be good to add filter by label.. so in such repos like substrate you could filter out the particular team tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll add a pagination system in a different commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #4 to handle it
Co-authored-by: Maksym Hlukhovtsov <1177472+mordamax@users.noreply.github.com>
Created GitHub action that fetches all the stale issues.
Created documentation explaining how to use it.