-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement node endpoints #226
Conversation
Test node transaction pool Test node version Add return types for services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need to get the latest block and metadata, except maybe for tx pool to decode calls. Could use docs on what is being returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks...this will be a great addition 🚗
* - `clientImplVersion` Node's implementation's version. | ||
* - `clientImplName` Node's implementation name. | ||
* - `chain` Chain's spec name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these a little jazzier.
Closes #225
Closes #168
Closes #220
Overview
This PR implements the node endpoints as specified in the
openapi-proposal.yaml
. This includesnode/version
,node/transaction-pool
, andnode/network
.For each, the code lightly wraps RPC calls. For
system_peers
, it was found that Parity public nodes do not support the RPC call, so it was wrapped in a try/catch block, and puts in a message if the RPC method does not work.Bare bones unit tests are implemented to have some degree of a user contract that can be used to show regressions. So far though I have not been able to fully test
node/transaction-pool
as there has been no pending extrinsic.Follow up PRs