Add specName and chainName to Artifacts #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahah, actually yeah: https://polkadot.js.org/api/substrate/rpc.html#chain-text |
danforbes
approved these changes
Jun 6, 2020
emostov
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specNamecomes from an RPC call but AFAICT, nothing returns thechainNamefor the registry. Used a switch/case block here but I could see many possible approaches to this:Leave as is. The reason I did this is because TxWrapper's registry will only accept'Polkadot' | 'Kusama' | 'Westend', so I explicitly filter for them here.Remove the switch/case and just do thedefaultblock now, which capitalizes the first letter ofspecName. This assumes that all chains and the Polkadot JS API type registry will follow thisspecName/chainNamepattern.Just removechainNamefrom the return entirely and let people deal with thisspecName -> chainNameconversion on the outside.chainNameand this is all pointless.To release only after paritytech/txwrapper#161 is in a txwrapper release.