Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version flag to update-pjs scripts #65

Open
TarikGul opened this issue Apr 22, 2022 · 3 comments
Open

Add version flag to update-pjs scripts #65

TarikGul opened this issue Apr 22, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TarikGul
Copy link
Member

When calling substrate-update-pjs-deps there is no way to currently specify a version you would like to set the packages and resolutions too. It would be nice to be able to pass in a flag, and it will update all the version to the set value. To implement this would be pretty straight forward, as no fetching is required. In main() we would just have a quick check that says something like argv.version || fetchRelease()['tag_name']

@TarikGul TarikGul added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2022
@mlshv
Copy link

mlshv commented May 6, 2022

Hello there! I'd like to contribute on this issue. But I don't get how it is supposed to work. As I can see, not all the @polkadot packages have the same version number.

Снимок экрана 2022-05-06 в 13 37 41

For example, how do I set version of @polkadot/apps-config?

@TarikGul

@TarikGul
Copy link
Member Author

TarikGul commented May 6, 2022

Great point, that is totally correct and a good catch. We'll have to specify a package group as well. Maybe we set the flag for the package too --packageVersion -> which the value passed in could be expected to be like: apps-config@3.1.1, that way we know the package, and the corresponding version.

@TarikGul
Copy link
Member Author

TarikGul commented May 6, 2022

Would take some simple parsing/splitting but that's the first thing that came to mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants