This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Put back CI=true when running on CI #915

Open

amaury1093 opened this issue Apr 17, 2020 · 0 comments

Labels

Contributor

amaury1093 commented Apr 17, 2020 •

edited

Loading

In #896, I added CI=false in the yarn build:extension step: https://github.com/paritytech/substrate-light-ui/pull/896/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R22

This is to avoid a known webpack issue around dynamic requires, introduced by using wasm, see for example rustwasm/wasm-pack#822:

Critical dependency: the request of a dependency is an expression

It's really not critical, and everything works with this CI=false. Just a reminder issue.

The text was updated successfully, but these errors were encountered:

amaury1093 added the F3-annoyance label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.