Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afg.finalized being read by substrate-telemetry, but not being sent by substrate #427

Closed
kishansagathiya opened this issue Nov 11, 2021 · 2 comments

Comments

@kishansagathiya
Copy link

afg.finalized being read by substrate-telemetry, but not being sent by substrate. I am saying that by searching for afg.finalized in substrate code. Is that the case?
Why so? I substrate-telemetry expecting telemetry from any other parties?

@jsdw
Copy link
Collaborator

jsdw commented Nov 15, 2021

Interesting! I also can't find any reference to "aura.pre_sealed_block", which is ignored but known about by telemetry.

My guess without checking would be that these were once emitted in older versions of substrate but aren't any longer.

We should probably remove them. (I'm not sure but I wonder whether "afg.finalized" became "afg.finalized_blocks_up_to" at some point, or whether we should handle the latter like wecurrently do the former)

@jsdw
Copy link
Collaborator

jsdw commented Dec 10, 2021

We trimmed down the messages that telemetry looks for somewhat recently, including removing any that were no logner sent, so I'll close this now. Thanks for highlighting it! :)

@jsdw jsdw closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants