Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Prevent pallet version inconsistency #13062

Closed
ggwpez opened this issue Jan 4, 2023 · 2 comments · Fixed by #13417
Closed

Prevent pallet version inconsistency #13062

ggwpez opened this issue Jan 4, 2023 · 2 comments · Fixed by #13417
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@ggwpez
Copy link
Member

ggwpez commented Jan 4, 2023

Currently we have the soft assumption that on_chain_storage_version() == current_storage_version() for all pallets.
There are indications that this does not hold for all pallets on Rococo. It would be nice to have a post-migration check which asserts this so that no migrations can be forgotten.
@ggwpez ggwpez added J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Jan 4, 2023
@bkchr
Copy link
Member

bkchr commented Jan 4, 2023

Yeah, I have already started working on this. I need to finish it :P

@ggwpez
Copy link
Member Author

ggwpez commented Feb 1, 2023

I wrote a draft to check Rococo here master...oty-check-pallet-versions
Seems like there are issues with it. Does your code look much different @bkchr ?

@ggwpez ggwpez mentioned this issue Feb 1, 2023
Closed
9 tasks
@bkchr bkchr mentioned this issue Feb 19, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of unset StorageVersion paritytech/substrate
2 participants
@bkchr @ggwpez