Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fast-unstake benchmarks are too slow #13077

Closed
ggwpez opened this issue Jan 5, 2023 · 1 comment · Fixed by #13120
Closed

Fast-unstake benchmarks are too slow #13077

ggwpez opened this issue Jan 5, 2023 · 1 comment · Fixed by #13120
Assignees
@kianenigma
Labels
U2-some_time_soon Issue is worth doing soon.

Comments

@ggwpez
Copy link
Member

ggwpez commented Jan 5, 2023 •
edited
Loading

Benchsuite running since 14 hrs on ref hardware. Fast-unstake taking up the majority of that.
Looking at the quick-benchmarks Substrate CI shows that it is the on_idle_check which even with --steps 2 --repeat 1 takes 10 minutes:

09:18:00 Starting benchmark: pallet_fast_unstake::on_idle_check
09:18:06 Running Benchmark: pallet_fast_unstake.on_idle_check(1 args) 1/2 1/1
09:28:41 Running Benchmark: pallet_fast_unstake.on_idle_check(1 args) 2/2 1/1

Kusama does not suffer from this, so probably just parameters?

cc @kianenigma
@ggwpez ggwpez added the U2-some_time_soon Issue is worth doing soon. label Jan 5, 2023
@ggwpez ggwpez mentioned this issue Jan 5, 2023
Merged
8 tasks
@kianenigma
Copy link
Contributor

will take a look soon.

@kianenigma kianenigma self-assigned this Jan 10, 2023
@kianenigma kianenigma mentioned this issue Jan 10, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kianenigma kianenigma

Labels
U2-some_time_soon Issue is worth doing soon.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduce exec time of fast-unstake benchmarks paritytech/substrate
2 participants
@kianenigma @ggwpez