Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Memory leak #3085

Closed
iammelea opened this issue Jun 27, 2019 · 13 comments
Closed

Memory leak #3085

iammelea opened this issue Jun 27, 2019 · 13 comments
Assignees

Comments

@iammelea
Copy link

Hello, validating in Poc-4 Alexander and we can see how the use of memory increases over time. here pic.
Screenshot from 2019-06-20 14-31-33

Screenshot from 2019-06-27 17-17-47

after stop and start the Polkadot process, the memory is back to a low level and starts increases over time again.

@laboon
Copy link

laboon commented Jun 27, 2019

Note that apparently after running out of memory, validator nodes will get slashed as offline, so this is problematic for those running validator nodes.

@iammelea
Copy link
Author

iammelea commented Jun 27, 2019

I have one node running without validator key and the memory is not increasing like in the validator node.

@kianenigma
Copy link
Contributor

what's the upper bound of this increase? the node just keeps allocating until it crashes or it stops at some point? If the latter, then maybe this is not actually an unexpected behavior.

@iammelea
Copy link
Author

1.-what's the upper bound of this increase?
go to check these next days.

2.- the node just keeps allocating until it crashes or it stops at some point?
So I can see in my case I think it reaches a top and stays there in 1.3GB, in my case the node has never crashed. but my server is very light of work. and in telemetrics I can see anothers nodes up to 1.3GB ussage.

@kianenigma
Copy link
Contributor

1.-what's the upper bound of this increase?
go to check these next days.

2.- the node just keeps allocating until it crashes or it stops at some point?
So I can see in my case I think it reaches a top and stays there in 1.3GB, in my case the node has never crashed. but my server is very light of work. and in telemetrics I can see anothers nodes up to 1.3GB ussage.

Okay, I see. I don't suggest that it is a false alarm but it is also not super strange for a software which is not yet developed with optimization in mind to allocate (gradually) around 1Gb of memory.

@iammelea
Copy link
Author

iammelea commented Jul 1, 2019

just updating the issue
memory is increasing on time, validator or not validator node.
Screenshot from 2019-07-01 16-36-52

@gavofyork gavofyork transferred this issue from paritytech/polkadot Jul 10, 2019
@gavofyork gavofyork changed the title the use of memory increases over time Memory leak Jul 10, 2019
@arkpar arkpar self-assigned this Jul 11, 2019
@bkchr
Copy link
Member

bkchr commented Jul 11, 2019

@iammelea could you try to replicate this with latest master and a small local chain?

@arkpar
Copy link
Member

arkpar commented Jul 12, 2019

Can't reproduce it on a local chain. The memory grows a bit, but that's mostly database cache.

@iammelea
Copy link
Author

iammelea commented Jul 12, 2019

@arkpar .Yes grow a bit time to time. Not is a quickly grow.

If need @bkchr

I can try to run one local small testnet this weekend but if @arkpar can still keep runing one too. Can be very helpful

@bkchr
Copy link
Member

bkchr commented Jul 13, 2019

I recently fixed some memory leak in Polkadot, maybe that solves your problem. But this was no "big" memory leak, so I'm not sure if it was the reason of your problem.

@arkpar
Copy link
Member

arkpar commented Jul 31, 2019

Identified a leak here: https://github.com/libp2p/rust-libp2p/blob/2fd941122a6c589501ad1c04b0f091f1337f5f49/protocols/kad/src/behaviour.rs#L1399
@romanb

@romanb
Copy link
Contributor

romanb commented Aug 1, 2019

@arkpar Thanks for the heads-up. libp2p/rust-libp2p#1217 should address that.

@iammelea
Copy link
Author

iammelea commented Nov 6, 2019

v0.6.9 is out lets close this old issue

@iammelea iammelea closed this as completed Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants