Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Extract "consensus" module from Service #942

Closed
rphmeier opened this issue Oct 21, 2018 · 1 comment
Closed

Extract "consensus" module from Service #942

rphmeier opened this issue Oct 21, 2018 · 1 comment
Labels
I7-refactor Code needs refactoring.
Milestone
Polkadot

Comments

@rphmeier
Copy link
Contributor

Block-authorship logic is often going to be very chain-specific, so it doesn't make sense to implement this in Service.

We should extract to a library crate in core as substrate-typical-authorship or something like that.
@rphmeier rphmeier added the I7-refactor Code needs refactoring. label Oct 21, 2018
@rphmeier rphmeier added this to the 1.0 beta milestone Oct 21, 2018
@rphmeier rphmeier modified the milestones: 1.0 beta, 1.0 (final) Nov 26, 2018
@gavofyork gavofyork modified the milestones: 1.0 (final), 1.x series Dec 18, 2018
@rphmeier
Copy link
Contributor Author

This was done #1158

lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gavofyork
Companion for paritytech#5412 (paritytech#942)
d4f0a74 
* Fixes for democracy using Scheduler

* Revert branch change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Milestone
Polkadot
Development

No branches or pull requests
2 participants
@gavofyork @rphmeier