Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put integration tests behind feature flag to avoid need for substrate on PATH #351

Closed
jsdw opened this issue Dec 3, 2021 · 0 comments · Fixed by #515
Closed

Put integration tests behind feature flag to avoid need for substrate on PATH #351

jsdw opened this issue Dec 3, 2021 · 0 comments · Fixed by #515
Labels
good first issue Small, well scoped, simple; good for newcomers

Comments

@jsdw
Copy link
Collaborator

jsdw commented Dec 3, 2021

Currently, running cargo test requires a substrate binary on your PATH. This used to be a runtime error (and only the affected tests would fail), but now it is a compile-time error because we now generate the runtime details at build time against the substrate binary we'll point at for tests.

I'd suggest hiding the integration tests behind an integration-tests feature flag, so that this is not the case.

If any files are generated (cargo c --tests is reported to have left behind a client/dev-chain.json file for instance), put generation of them behind the feature flag if applicable, and at least write them to a temp fodlere if possible.

@jsdw jsdw mentioned this issue Feb 1, 2022
16 tasks
@jsdw jsdw added the good first issue Small, well scoped, simple; good for newcomers label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Small, well scoped, simple; good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant