Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subxt integration tests failed against latest Substrate build. #491

Closed
github-actions bot opened this issue Mar 26, 2022 · 3 comments · Fixed by #492
Closed

Subxt integration tests failed against latest Substrate build. #491

github-actions bot opened this issue Mar 26, 2022 · 3 comments · Fixed by #492

Comments

@github-actions
Copy link

The nightly CI run which downloads the latest version of Substrate ran into test failures, which likely means that there are breaking changes that need fixing in Subxt.

Go to https://github.com/paritytech/subxt/actions/workflows/nightly.yml to see details about the failure.

@lexnv
Copy link
Contributor

lexnv commented Mar 28, 2022

Details

The error is generated by

 error[E0308]: mismatched types
 --> /home/runner/work/subxt/subxt/target/debug/build/test-runtime-eeeace8618671647/out/runtime.rs:2:9
  |
2 | /         #[subxt::subxt(
3 | |             runtime_metadata_path = "/home/runner/work/subxt/subxt/target/debug/build/test-runtime-eeeace8618671647/out/metadata.scale",
4 | |             generated_type_derives = "Eq, PartialEq"
5 | |         )]
  | |__________^ expected `u8`, found array `[u8; 4]`
  |
  = note: this error originates in the attribute macro `subxt::subxt` (in Nightly builds, run with -Z macro-backtrace for more info)

It might be possible that substrate introduced changes that are not reflected yet in subxt.

Run curl $SUBSTRATE_URL --output substrate --location
  curl $SUBSTRATE_URL --output substrate --location
  chmod +x substrate
  mkdir -p ~/.local/bin
  mv substrate ~/.local/bin
  shell: /usr/bin/bash -e {0}
  env:
    CARGO_TERM_COLOR: always
    SUBSTRATE_URL: https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate

I have seen this exact issue happen once in #478 , during multiple commit pushes, and expected that a wrong substrate binary was temporarily released.

Next Step

  • reproduce locally
  • identify the issue
  • push PR

@lexnv
Copy link
Contributor

lexnv commented Mar 28, 2022

Substrate binary is resolved to 65b44e91be - add notes and warnings to ProvideInherent docs (#9730) from the current head of origin/master.

@lexnv
Copy link
Contributor

lexnv commented Mar 28, 2022

Change introduced in substrate via commit 6c92fc317bb - PR Allow pallet error enum variants to contain fields #10242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant