Upgrade to v0.9.40

[valentinfernandez1]

Upgrades from polkadot-v0.9.37 to polkadot-v0.9.40 introducing XCM V3 and Weights V2. The detailed description of changes can be found here.

Polkadot v0.9.38
Polkadot v0.9.39
Polkadot v0.9.40

The upgrade introduced a lot of changes so feel free to comment on anything that could be improved or revised before the merge.

Significant Changes and Future Improvements

Replaced AssetIdfor AssetIdForTrustBackedAssets .

Modified in version v0.9.38 AssetId changed name implying that the Id comes from a TrustBackedAsset which based on the fact that this are intended to be minted on statemine would make sense.

impl pallet_assets::Config for Runtime {
	...
	type AssetId = AssetIdForTrustBackedAssets;
	...
}

In case we wanted to add assets from an untrusted source we could take some inspiration from cumulus where there's 2 instances of pallet_assets (Trusted and ForeignAssets)

pub type TrustBackedAssetsInstance = pallet_assets::Instance1;
type TrustBackedAssetsCall = pallet_assets::Call<Runtime, TrustBackedAssetsInstance>;
impl pallet_assets::Config<TrustBackedAssetsInstance> for Runtime {
   ...
}
...
pub type ForeignAssetsInstance = pallet_assets::Instance2;
impl pallet_assets::Config<ForeignAssetsInstance> for Runtime {
	type AssetId = MultiLocationForAssetId;
	type AssetIdParameter = MultiLocationForAssetId;
	type CreateOrigin = ForeignCreators<
		(FromSiblingParachain<parachain_info::Pallet<Runtime>>,),
		ForeignCreatorsSovereignAccountOf,
		AccountId,
	>;
	type AssetDeposit = ForeignAssetsAssetDeposit;
	type MetadataDepositBase = ForeignAssetsMetadataDepositBase;
	type MetadataDepositPerByte = ForeignAssetsMetadataDepositPerByte;
	type ApprovalDeposit = ForeignAssetsApprovalDeposit;
	type StringLimit = ForeignAssetsAssetsStringLimit;
	type AssetAccountDeposit = ForeignAssetsAssetAccountDeposit;
	...
}

Modified use of Weights

As part of the update to Weights V2 that introduced a new 2D system the functions and parameters using 1 dimensional weight were updated to include the new proof_size value. Egg:

pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000,0);

Contracts Pallet

Updated to follow paritytech/cumulus#2108

Added new fields for XCMv3

Configure pallet_xcm and xcm_executor with the new fields added in the newest XCM version.

impl pallet_xcm::Config for Runtime {
	...
	type Currency = Balances;
	type CurrencyMatcher = ();
	type MaxLockers = ();
	type SovereignAccountOf = ();
	type TrustedLockers = ();
	type UniversalLocation = UniversalLocation;
	// TODO: pallet-xcm weights
	type WeightInfo = pallet_xcm::TestWeightInfo;
	#[cfg(feature = "runtime-benchmarks")]
	type ReachableDest = ReachableDest;
}

Note: WeightInfo should be updated with the proper weights after benchmarking on #141.

Updated Pallets

Pallet-dex was updated to match Trappist version and weights were benchmarked again to match new weights format. Chess Pallet was removed due to errors causing large WASM files that would conflict with Validators on the relay chain.

Refactor of Node Service
The library for cumulus_client_service was modified so the Node service had to be changed following Parachain template update to v0.9.40 PR

Closes #164

[valentinfernandez1]

I suggest opening a separate issue to address the WeightToFee implementation. This will prevent this PR from becoming too bloated. By separating them, we can focus on each issue independently, making it easier for reviewers to understand and provide feedback.

That way we can discuss and collaborate specifically on the WeightToFee implementation there.

[kalaninja]

I checked the changes made for parachain-template while migrating. LGTM. The only thing that caught my eye was that they added a hardware check. Might be worth having it too.

[valentinfernandez1]

I checked the changes made for parachain-template while migrating. LGTM. The only thing that caught my eye was that they added a hardware check. Might be worth having it too.

Good catch, I missed that!

[hbulgarini]

Besides my comments i would like to add some items needed for migration that were not in the list and explain the reason why:

LocalFungiblesTransactor: Replace Nothing for xcm_builder::NoChecking.
CheckAccount: Add the MintLocation.
Adding GlobalConsensus for UniversalLocation type.

[stiiifff]

FYI I cherry-picked @kalaninja CI fixes so we get CI checks on this PR and on the xcmv3-dev branch.

[valentinfernandez1]

Had to the CI because currently it runs out of memory and fails. I'm working on a fix for this but I will add it alongside #175 .

[hbulgarini]

LGTM. Thanks for addressing the feedback valentin.

[stiiifff]

FYI I ran the CI tasks locally just to be sure. All is green ✅️
LGTM