Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays out the traits needed to solve paritytech/substrate#872 (comment), to support multiple hashing algorithms in multi-trie.
Because we can't know how many children tries are created, multi-trie needs to write all hashdb values into a single storage. To support multiple hash algorithms, the length of the hash might also be different, while the underlying data store might expect a fixed length hash. With traits in this PR, we can fix both of the issues:
PlainDB
reference in children delta trie root generation. The generation function wrapsPlainDB
into anotherHashDB
of the targeted hash algorithm to continue the operation.PlainDB
.H::hash(key)
before passing it back toPlainDB
.This PR should be backward-compatible. The only case where it breaks is if a file tries to do
use hash_db::*
.