Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Readme #308

Closed
pgolovkin opened this issue Jun 30, 2023 · 1 comment · Fixed by #310
Closed

Typo in Readme #308

pgolovkin opened this issue Jun 30, 2023 · 1 comment · Fixed by #310

Comments

@pgolovkin
Copy link

Hey!

I've found env variables in the readme.md. There is a typo https://github.com/paritytech/txwrapper-core/blob/main/packages/txwrapper-core/README.md#txwrapper_metadata_cache_max-1
TXWRAPPER_METADATA_CACHE_MAX has to be replaced to TXWRAPPER_METADATA_CACHE_MAX_AGE

txwrapper-core/packages/txwrapper-core/src/core/metadata/createMetadata.ts

Line 54 in 86d9620

export const createMetadata = memoizee(createMetadataUnmemoized, {

@TarikGul
Copy link
Member

TarikGul commented Jul 3, 2023

Ahh thanks for reporting this, will get this fixed.

@TarikGul TarikGul mentioned this issue Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix Metadata cache args paritytech/txwrapper-core
2 participants
@pgolovkin @TarikGul