-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate system, and session txwrapper methods #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that one question on if the proof
for setKeys
is used. Also make sure to export the methods from txwrapper-polkadot
as well.
@emostov I noticed I didn't export the other methods in The follows methods im going to add to be exported in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo doc nitpick on the proof
param.
Co-authored-by: David <dvdplm@gmail.com>
Info
This PR aims to migrate the
system
andsession
methods from txwrapper to txwarpper-core =>packages/txwrapper-substrate
.Changelog
packages/txwrapper-substrate/src/methods/system
Added
remark
packages/txwrapper-substrate/src/methods/session
Added
setKeys