Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate system, and session txwrapper methods #51

Merged
merged 10 commits into from
Feb 19, 2021

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Feb 7, 2021

Info

This PR aims to migrate the system and session methods from txwrapper to txwarpper-core => packages/txwrapper-substrate.

Changelog

packages/txwrapper-substrate/src/methods/system

Added remark

packages/txwrapper-substrate/src/methods/session

Added setKeys

@TarikGul TarikGul changed the title Migrate remaining txwrapper methods feat: migrate system, and session txwrapper methods Feb 7, 2021
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one question on if the proof for setKeys is used. Also make sure to export the methods from txwrapper-polkadot as well.

@TarikGul
Copy link
Member Author

@emostov I noticed I didn't export the other methods in txwrapper-polkadot in the last few PR's as well so I am also going to add it in this PR.

The follows methods im going to add to be exported in txwrapper-polkadot are:

  • democracy
  • session
  • staking
  • system
  • vesting

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo doc nitpick on the proof param.

@TarikGul TarikGul merged commit 3f0ed07 into main Feb 19, 2021
@TarikGul TarikGul deleted the migrate-remaining-txwrapper-methods branch February 19, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants