Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Executable refactoring and no_std support #77

Merged
merged 8 commits into from
May 15, 2018
Merged

Executable refactoring and no_std support #77

merged 8 commits into from
May 15, 2018

Conversation

sorpaas
Copy link
Member

@sorpaas sorpaas commented May 15, 2018

  • Move executables to separate crates. In this way, we can get minimal dependencies for core util library.
  • Add no_std support for core util library. In particular, BTree map and set will be used when in no_std.
  • Temporarily depend on git version of parity-wasm until no_std is released.

Closes #76

@sorpaas sorpaas requested review from pepyakin and NikVolf May 15, 2018 00:33
@lexfrl
Copy link
Contributor

lexfrl commented May 15, 2018

just tried to cargo install.cargo install is not looking trough workspace for binaries.
https://github.com/paritytech/wasm-utils#build-tools-for-cargo

cargo install
error: no packages found with binaries or examples

I'm not sure, maybe it will still work in case if we install it from crates.io though

@sorpaas
Copy link
Member Author

sorpaas commented May 15, 2018

@fckt Yeah looks like after splitting the executable, it would need to be installed individually. rust-lang/cargo#4101

@pepyakin
Copy link
Contributor

AFAIR, we already using cargo install pwasm-utils --bin wasm-build for quite some time? Or am I missing something?

@NikVolf
Copy link
Contributor

NikVolf commented May 15, 2018

we will have to publish every binary package separately?

@sorpaas
Copy link
Member Author

sorpaas commented May 15, 2018

@NikVolf Yes, but we can also combine it together. Which way do we prefer?

@NikVolf
Copy link
Contributor

NikVolf commented May 15, 2018

Yeah, i think all executables should be in one place at least.

Package "pwasm-utils-cli" would be great

Copy link
Contributor

@NikVolf NikVolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, though @pepyakin wants to play with it before it's merged?

@pepyakin
Copy link
Contributor

Already playing, looks good so far : )

@lexfrl
Copy link
Contributor

lexfrl commented May 15, 2018

We should make sure the install command will continue to work. Otherwise we have to edit .travis.yml's in all projects which are using wasm-build

@NikVolf
Copy link
Contributor

NikVolf commented May 15, 2018

@fckt not a big deal, we'll just have to change to cargo install pwasm-utils-cli

@pepyakin
Copy link
Contributor

Great!

@pepyakin
Copy link
Contributor

pepyakin commented May 15, 2018

But can we release parity-wasm and use the released version there?

UPD: Done!

@pepyakin pepyakin merged commit 60a7776 into master May 15, 2018
@athei athei deleted the sorpaas/nostd branch July 27, 2021 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants