Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ConstRef based on u32 instead of intx::U24 #727

Merged
merged 13 commits into from
May 29, 2023
Merged

Conversation

Robbepop
Copy link
Member

This allows us to remove intx dependency. This was an oversight in a previous PR.

This allows us to remove intx dependency.
@Robbepop Robbepop changed the title make ConstRef based on u32 make ConstRef based on u32 instead of intx::U24 May 28, 2023
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented May 28, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.54ms 1.55ms 🔴 1.24% 1.07ms 1.03ms 🟢 -3.05% 🟢 -33%
execute/
bare_call_0/typed
1.15ms 1.19ms 🔴 3.81% 685.87µs 657.30µs 🟢 -4.24% 🟢 -45%
execute/
bare_call_1
1.60ms 1.59ms 🟢 0.85% 1.19ms 1.18ms 🟢 -1.08% 🟢 -26%
execute/
bare_call_16
2.53ms 2.48ms 🟢 -2.33% 3.31ms 3.26ms 🟢 -1.53% 🟢 31%
execute/
bare_call_16/typed
1.51ms 1.52ms ⚪ 0.00% 1.82ms 1.65ms 🟢 -9.41% 🟢 9%
execute/
bare_call_1/typed
1.25ms 1.26ms ⚪ 1.07% 1.01ms 981.65µs 🟢 -2.58% 🟢 -22%
execute/
bare_call_4
1.72ms 1.74ms ⚪ 1.50% 1.64ms 1.63ms 🟢 0.86% 🟢 -6%
execute/
bare_call_4/typed
1.22ms 1.21ms ⚪ -0.49% 964.78µs 903.45µs 🟢 -6.41% 🟢 -25%
execute/
br_table
1.34ms 1.34ms ⚪ 0.33% 1.21ms 1.21ms ⚪ 0.29% 🟢 -10%
execute/
count_until
577.03µs 680.30µs 🔴 17.90% 1.16ms 1.28ms 🔴 10.22% 🟡 88%
execute/
factorial_iterative
327.91µs 319.36µs 🟢 -2.69% 539.55µs 536.86µs ⚪ -0.48% 🟡 68%
execute/
factorial_recursive
510.78µs 512.49µs ⚪ 0.57% 673.53µs 670.57µs ⚪ -0.59% 🟢 31%
execute/
fibonacci_iter
1.40ms 1.40ms ⚪ 0.00% 2.94ms 2.65ms 🟢 -9.76% 🟡 90%
execute/
fibonacci_rec
4.31ms 4.17ms 🟢 -3.11% 6.43ms 6.11ms 🟢 -4.93% 🟢 46%
execute/
fibonacci_tail
892.47µs 921.22µs 🔴 3.31% 1.51ms 1.53ms 🔴 1.54% 🟡 66%
execute/
global_bump
704.99µs 798.06µs 🔴 13.21% 1.54ms 1.72ms 🔴 11.40% 🔴 115%
execute/
global_const
682.51µs 738.67µs 🔴 8.27% 1.31ms 1.37ms 🔴 4.21% 🟡 85%
execute/
host_calls
35.86µs 36.55µs 🔴 1.98% 41.74µs 40.71µs 🟢 -2.40% 🟢 11%
execute/
memory_fill
1.14ms 1.21ms 🔴 5.99% 2.21ms 2.23ms ⚪ 1.05% 🟡 84%
execute/
memory_sum
1.13ms 1.15ms 🔴 1.67% 2.43ms 2.26ms 🟢 -7.18% 🟡 96%
execute/
memory_vec_add
2.24ms 2.37ms 🔴 5.75% 4.37ms 4.42ms ⚪ 1.11% 🟡 86%
execute/
recursive_is_even
710.17µs 688.20µs ⚪ -1.64% 1.05ms 990.82µs 🟢 -5.42% 🟢 44%
execute/
recursive_ok
100.17µs 101.02µs ⚪ 0.90% 148.90µs 145.90µs 🟢 -1.96% 🟢 44%
execute/
recursive_scan
133.71µs 136.15µs 🔴 1.83% 194.71µs 190.11µs 🟢 -2.42% 🟢 40%
execute/
recursive_trap
9.65µs 9.67µs ⚪ 0.46% 14.75µs 14.85µs ⚪ 0.63% 🟡 54%
execute/
regex_redux
465.89µs 472.02µs 🔴 1.91% 826.37µs 794.37µs 🟢 -3.94% 🟡 68%
execute/
rev_complement
431.12µs 434.34µs ⚪ 0.69% 852.14µs 797.21µs 🟢 -6.55% 🟡 84%
execute/
tiny_keccak
326.58µs 323.59µs ⚪ -0.82% 658.08µs 674.70µs 🔴 2.69% 🔴 109%
execute/
trunc_f2i
729.97µs 739.48µs 🔴 1.28% 1.65ms 1.56ms 🟢 -5.37% 🔴 112%
instantiate/
wasm_kernel
53.91µs 53.72µs ⚪ -0.30% 55.72µs 59.58µs 🔴 7.77% 🟢 11%
translate/
erc1155
196.71µs 197.20µs ⚪ 0.40% 444.96µs 435.53µs 🟢 -2.50% 🔴 121%
translate/
erc20
97.87µs 96.79µs ⚪ -1.04% 218.83µs 207.72µs 🟢 -4.44% 🔴 115%
translate/
erc721
137.29µs 137.46µs ⚪ 0.03% 309.10µs 303.25µs 🟢 -4.27% 🔴 121%
translate/
spidermonkey
61.25ms 60.85ms ⚪ -0.58% 0.00ns 0.00ns ⚪ 0.13% 🟢 -100%
translate/
wasm_kernel
3.97ms 3.93ms ⚪ -0.61% 8.00ms 8.04ms ⚪ 0.17% 🔴 104%

Link to pipeline

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #727 (abbc464) into master (4fb164c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files         102      102           
  Lines        8755     8755           
=======================================
  Hits         6924     6924           
  Misses       1831     1831           
Impacted Files Coverage Δ
crates/wasmi/src/engine/const_pool.rs 81.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 799995d into master May 29, 2023
@Robbepop Robbepop deleted the rf-remove-intx branch May 29, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants