Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/config builders #51

Merged
merged 40 commits into from
May 30, 2023
Merged

Feat/config builders #51

merged 40 commits into from
May 30, 2023

Conversation

l0r1s
Copy link
Contributor

@l0r1s l0r1s commented May 22, 2023 •
edited
Loading

  • Add configuration

    • Node
    • Relaychain
    • Parachain
    • HRMP channels
    • Network

  • Add builders

    • Node
    • Relaychain
    • Parachain
    • HRMP channels
    • Network

  • Add tests for builders

    • Node
    • Relaychain
    • Parachain
    • HRMP channels
    • Network

@l0r1s l0r1s requested review from pepoviola and wirednkod May 22, 2023 12:09
wirednkod
wirednkod reviewed May 23, 2023
View reviewed changes
crates/configuration/src/network.rs Outdated Show resolved Hide resolved
crates/configuration/src/parachain.rs Outdated Show resolved Hide resolved
crates/configuration/src/relaychain.rs Outdated Show resolved Hide resolved
@l0r1s
chore: refacto Path/DbSnapshot into AssetLocation and updated dependa…
bd99193 
…nt code, Timeout to Duration, visibility of public methods
@l0r1s l0r1s marked this pull request as ready for review May 29, 2023 17:30
@l0r1s l0r1s requested review from pepoviola and wirednkod May 30, 2023 00:21
pepoviola
pepoviola requested changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of small changes and I think we have room to simplify some things. Awesome progress, I think we should merge and keep building on-top.
Thanks!

@pepoviola pepoviola self-requested a review May 30, 2023 13:13
@pepoviola pepoviola merged commit 8395d48 into main May 30, 2023
2 checks passed
@pepoviola pepoviola deleted the feat/config-builders branch May 30, 2023 13:55
@l0r1s l0r1s mentioned this pull request Jun 1, 2023
Closed
12 tasks
This was referenced Jun 26, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@wirednkod wirednkod Awaiting requested review from wirednkod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@l0r1s @pepoviola @wirednkod