Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ads Manager exercise #4

Merged
merged 13 commits into from
Nov 19, 2022
Merged

Conversation

YaraWS
Copy link
Contributor

@YaraWS YaraWS commented Nov 11, 2022

  • Couldn't insert the searching symbol inside the search box
  • Had some dificulty aligning the tittle on top of the table

@parkejunior
Copy link
Owner

The exercise is correctly organized inside its folder, but to follow the pattern, please put it inside the directory like /[language]/[exercise title]/[username].

@parkejunior parkejunior changed the title First commit Add Ads Manager exercise Nov 12, 2022
@parkejunior
Copy link
Owner

i changed the title for readability. "First commit" don't explain about this pull request.

@YaraWS
Copy link
Contributor Author

YaraWS commented Nov 18, 2022

I hope the pattern is correct. Follow the cargo design agency files.

@parkejunior
Copy link
Owner

The exercise follows the pattern correctly, but this issue is only for the Ads Manager exercise and its files remain inside the exercise's root folder. Please, you should open a new pull request for Cargo Design Agency exercise.

@YaraWS
Copy link
Contributor Author

YaraWS commented Nov 19, 2022

  • I moved the files from Ads Manager into a folder named yara
  • I deleted the folder Cargo Design

@parkejunior parkejunior merged commit 58479ca into parkejunior:main Nov 19, 2022
@parkejunior
Copy link
Owner

Ok, that's great! You should add more changes when you need.

@parkejunior parkejunior linked an issue Nov 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercício: Ads Manager UI
2 participants