Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail builds #5

Merged
merged 8 commits into from May 17, 2023
Merged

Don't fail builds #5

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6adc22d
Only hit compiler error during tests. Still shows error in editor.
parker-codes May 15, 2023
1c68a4a
Never fail? Try deprecation warning.
parker-codes May 15, 2023
28e64d8
Adjust to include trybuild and regular tests.
parker-codes May 15, 2023
0ed5bb4
Move past_date back into failures.
parker-codes May 15, 2023
81b1e09
Switch to must_use instead of deprecated.
parker-codes May 16, 2023
5f73db7
Update notes. Cleanup implementation.
parker-codes May 16, 2023
72873ae
Update past_date stderr output (cleaner).
parker-codes May 16, 2023
25d6357
Update note.
parker-codes May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/lib.rs
View file
Open in desktop
Expand Up @@ -52,7 +52,18 @@ pub fn todo_by(item: TokenStream) -> TokenStream {
} else {
format!("TODO by {date_str} has passed")
};
return quote! { compile_error!(#error_message); }.into();

// This works to trigger an error message, but has the negative side effect of
// causing tests to fail that reach an expiration.
return quote! {
#[cfg(any(test, trybuild))]
compile_error!(#error_message);

#[cfg(not(any(test, trybuild)))]
#[must_use = #error_message]
const t: () = ();
}
.into();
}

TokenStream::new()
Expand Down