ci: Run Playwright against alpha.cartokit.dev in production. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
parkerziegler
force-pushed
the
ci/run-against-alpha-cartokit-dev
branch
from
0741ec4
to
edcd062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address an issue unintentionally missed in #211.
Currently, we run our Playwright e2e tests against Vercel's deployment urls, even in production. However, our production tile server (Stadia Maps) will reject requests from arbitrary Vercel deployments owing to its strict domain-based authentication scheme. We get around this in preview environments by using MapTiler with the
cartokitAPI key instead. In production, however, we want to run using Stadia's basemaps, which means running e2e tests against alpha.cartokit.dev directly.This PR conditionally sets our
PLAYWRIGHT_TEST_BASE_URLto alpha.cartokit.dev when we're in a production environment (e.g., on merge tomain).