Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Filter Bug #1468

Closed
jkmarx opened this issue Oct 13, 2016 · 1 comment · Fixed by #1490
Closed

Dashboard Filter Bug #1468

jkmarx opened this issue Oct 13, 2016 · 1 comment · Fixed by #1490
Assignees
Milestone

Comments

@jkmarx
Copy link
Member

jkmarx commented Oct 13, 2016

  • Specific code commit: 7969dc1
  • Version of the web browser and OS: 49.0.1, 10.11.6 El Capitan
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance):
    https://test.stemcellcommons.org/#/

Steps to reproduce

Please list all the actions and the input data used:

  1. Select own data set data set filter (note number returned)
  2. Select own and public data set filter (note number returned)
  3. Remove public data set filter and leave own selected (note number returned)

Observed behavior

screen shot 2016-10-13 at 11 54 17 am
screen shot 2016-10-13 at 11 54 35 am
screen shot 2016-10-13 at 11 54 47 am

Expected behavior

Filters should return consistent and correct data sets

Other combinations malfunction also. Please test different patterns.

@jkmarx
Copy link
Member Author

jkmarx commented Oct 18, 2016

API requests are sent only for the last item selected.

Filter method enables chaining according to comments below.
commons / data sets / interface
data set filter method:

   * Set the data source to the general data API and add a filter option.
   *
   * @method  filter
   * @author  Fritz Lekschas
   * @date    2015-10-08
   *
   * @param   {Object}  filter  Key value pairs of filters.
   *   E.g. `{'is_owner': true}`
   * @return  {Object}          Instance itself to enable chaining.
   */
  DataSet.prototype.filter = function (filter) {
    _search = false;

    // _browsePath = [];
    _clearOrderCache();
    _source = new DataSetDataApi(filter);

    return this;
  };```

@jkmarx jkmarx modified the milestones: v1.6.0, Next Oct 18, 2016
@jkmarx jkmarx self-assigned this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant