Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching the sharing status slows down an API call dramatically #758

Closed
flekschas opened this issue Oct 26, 2015 · 1 comment
Closed

Fetching the sharing status slows down an API call dramatically #758

flekschas opened this issue Oct 26, 2015 · 1 comment
Assignees
@scottx611x
Labels
api dataset enhancement important
Milestone
Ipswich

Comments

@flekschas
Copy link
Member

Background:
My admin has access to ~350 data sets. A single query for 10 datasets used to come at 50-70ms. With the sharing information being fetched the same query takes 500ms on average.

The particular line of code is this https://github.com/parklab/refinery-platform/blob/develop/refinery/core/api.py#L145
@flekschas flekschas added this to the Next milestone Oct 26, 2015
@ngehlenborg ngehlenborg modified the milestones: Next, Ipswich Nov 3, 2015
@ngehlenborg ngehlenborg assigned jkmarx and scottx611x and unassigned jkmarx Nov 3, 2015
@ngehlenborg
Copy link
Contributor

We could try to pull get_groups_with_perms(res) outside the loop and handle it similar to how we are handling the other two attributes.

flekschas added a commit that referenced this issue Nov 10, 2015
@flekschas
Improves general performance. Related to #759 and #758. This won't he…
8490fdd 
…lp much in case of many shared or public datasets though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottx611x scottx611x

Labels
api dataset enhancement important
Projects
None yet
Milestone
Ipswich
Development

No branches or pull requests
4 participants
@flekschas @ngehlenborg @scottx611x @jkmarx